On Mon, Aug 13, 2018 at 06:02:18PM +0800, jianchao.wang wrote:

Hi Ming

On 08/11/2018 03:12 PM, Ming Lei wrote:

quoted

Not necessary to reserve tags for admin queue since there isn't
many inflight commands in admin queue usually.

This change won't starve admin queue too because each blocked queue
has equal priority to get one new tag when one driver tag is released,
no matter it is freed from any queue.

We don't count the adminq into tags->active_queues,

Yes, just like without this patchset.

there maybe following side-effect following:
 - if send a admin request for the LUN_a, it may cause LUN_b cannot get request even though its
   budget is allowed. And when the admin request for LUN_a is completed, LUN_b may not be in the
   first batch to be waked up.

 - all the LUNs still have to share a limited budget of tags

It is nothing to do with where the admin request is sent, so no any
difference wrt. this issue between with and without this patchset,
right?


Thanks,
Ming