Re: [RFC PATCH 1/5] block: move call of scheduler's ->completed_request() hook
From: jianchao.wang <hidden>
Date: 2018-08-10 05:27:25
Hi Omar On 08/10/2018 04:26 AM, Omar Sandoval wrote:
quoted hunk ↗ jump to hunk
@@ -524,6 +524,9 @@ inline void __blk_mq_end_request(struct request *rq, blk_status_t error) blk_stat_add(rq, now); } + if (rq->internal_tag != -1) + blk_mq_sched_completed_request(rq, now); +
Is it OK to move the io scheduler completed callback into __blk_mq_end_request ? There is a relatively long distance between the __blk_mq_complete_request and __blk_mq_end_request, especially the driver's mq_ops.complete and the bio_endio. Thanks Jianchao