Re: [PATCH v2 5/9] block: Switch struct packet_command to use struct scsi_sense_hdr

[PATCH v2 0/9] block: Consolidate scsi sense buffer usage · Kees Cook <hidden> · 2018-07-31
[PATCH v2 1/9] ide-cd: Drop unused sense buffers · Kees Cook <hidden> · 2018-07-31
Re: [PATCH v2 1/9] ide-cd: Drop unused sense buffers · David Miller <davem@davemloft.net> · 2018-07-31
[PATCH v2 6/9] ide-cd: Remove redundant sense buffer · Kees Cook <hidden> · 2018-07-31
Re: [PATCH v2 6/9] ide-cd: Remove redundant sense buffer · David Miller <davem@davemloft.net> · 2018-07-31
Re: [PATCH v2 6/9] ide-cd: Remove redundant sense buffer · Christoph Hellwig <hch@infradead.org> · 2018-08-01
[PATCH v2 9/9] scsi: Check sense buffer size at build time · Kees Cook <hidden> · 2018-07-31
Re: [PATCH v2 9/9] scsi: Check sense buffer size at build time · Christoph Hellwig <hch@infradead.org> · 2018-08-01
[PATCH v2 5/9] block: Switch struct packet_command to use struct scsi_sense_hdr · Kees Cook <hidden> · 2018-07-31
Re: [PATCH v2 5/9] block: Switch struct packet_command to use struct scsi_sense_hdr · Christoph Hellwig <hch@infradead.org> · 2018-08-01
[PATCH v2 7/9] cdrom: Use struct scsi_sense_hdr internally · Kees Cook <hidden> · 2018-07-31
Re: [PATCH v2 7/9] cdrom: Use struct scsi_sense_hdr internally · Christoph Hellwig <hch@infradead.org> · 2018-08-01
[PATCH v2 8/9] libata-scsi: Move sense buffers onto stack · Kees Cook <hidden> · 2018-07-31
Re: [PATCH v2 8/9] libata-scsi: Move sense buffers onto stack · Christoph Hellwig <hch@infradead.org> · 2018-08-01
Re: [PATCH v2 8/9] libata-scsi: Move sense buffers onto stack · Tejun Heo <tj@kernel.org> · 2018-08-01
[PATCH v2 2/9] scsi: cxlflash: Drop unused sense buffers · Kees Cook <hidden> · 2018-07-31
[PATCH v2 3/9] scsi: build scsi_common.o for all scsi passthrough request users · Kees Cook <hidden> · 2018-07-31
Re: [PATCH v2 3/9] scsi: build scsi_common.o for all scsi passthrough request users · Bart Van Assche <hidden> · 2018-07-31
Re: [PATCH v2 3/9] scsi: build scsi_common.o for all scsi passthrough request users · "hch@infradead.org" <hch@infradead.org> · 2018-07-31
Re: [PATCH v2 3/9] scsi: build scsi_common.o for all scsi passthrough request users · Bart Van Assche <hidden> · 2018-07-31
Re: [PATCH v2 3/9] scsi: build scsi_common.o for all scsi passthrough request users · Kees Cook <hidden> · 2018-08-01
[PATCH v2 4/9] target: don't depend on SCSI · Kees Cook <hidden> · 2018-07-31
Re: [PATCH v2 4/9] target: don't depend on SCSI · Randy Dunlap <hidden> · 2018-08-06
Re: [PATCH v2 4/9] target: don't depend on SCSI · Kees Cook <hidden> · 2018-08-06
Re: [PATCH v2 4/9] target: don't depend on SCSI · Randy Dunlap <hidden> · 2018-08-07
Re: [PATCH v2 4/9] target: don't depend on SCSI · Christoph Hellwig <hch@lst.de> · 2018-08-07
Re: [PATCH v2 0/9] block: Consolidate scsi sense buffer usage · Jens Axboe <axboe@kernel.dk> · 2018-08-02
Re: [PATCH v2 0/9] block: Consolidate scsi sense buffer usage · Kees Cook <hidden> · 2018-08-02

From: Christoph Hellwig <hch@infradead.org>
Date: 2018-08-01 08:22:51
Also in: linux-ide, linux-scsi, lkml, target-devel

On Tue, Jul 31, 2018 at 12:51:50PM -0700, Kees Cook wrote:

There is a lot of needless struct request_sense usage in the CDROM
code. These can all be struct scsi_sense_hdr instead, to avoid any
confusion over their respective structure sizes. This patch is a lot
of noise changing "sense" to "sshdr", but the final code is more
readable to distinguish between "sense" meaning "struct request_sense"
and "sshdr" meaning "struct scsi_sense_hdr".

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help