Thread (6 messages) 6 messages, 3 authors, 2018-07-25

Re: [PATCH v3 2/3] block: move dif_prepare/dif_complete functions to block layer

From: Keith Busch <hidden>
Date: 2018-07-25 14:53:57
Also in: linux-nvme

On Wed, Jul 25, 2018 at 01:22:47PM +0200, Christoph Hellwig wrote:
quoted
+			pmap = kmap_atomic(iv.bv_page) + iv.bv_offset;
+			p = pmap;
Maybe:

			pmap = p = kmap_atomic(iv.bv_page) + iv.bv_offset;
Max pointed out that even with this, we're still calling kunmap_atomic()
with an address potentially at an offset from the page that was kmap'ed.
While currently harmless, perhaps for correctness:

 			pmap = kmap_atomic(iv.bv_page);
			p = pmap + iv.bv_offset;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help