Re: [PATCH 3/6] nvme: register ns_id attributes as default sysfs groups

[PATCH 0/6] genhd: register default groups with device_add_disk() · Hannes Reinecke <hare@suse.de> · 2018-07-30
[PATCH 1/6] genhd: drop 'bool' argument from __device_add_disk() · Hannes Reinecke <hare@suse.de> · 2018-07-30
Re: [PATCH 1/6] genhd: drop 'bool' argument from __device_add_disk() · Christoph Hellwig <hch@lst.de> · 2018-07-30
Re: [PATCH 1/6] genhd: drop 'bool' argument from __device_add_disk() · Hannes Reinecke <hare@suse.com> · 2018-07-30
Re: [PATCH 1/6] genhd: drop 'bool' argument from __device_add_disk() · Bart Van Assche <hidden> · 2018-08-13
[PATCH 2/6] block: genhd: add 'groups' argument to device_add_disk · Hannes Reinecke <hare@suse.de> · 2018-07-30
Re: [PATCH 2/6] block: genhd: add 'groups' argument to device_add_disk · Christoph Hellwig <hch@lst.de> · 2018-07-30
[PATCH 3/6] nvme: register ns_id attributes as default sysfs groups · Hannes Reinecke <hare@suse.de> · 2018-07-30
Re: [PATCH 3/6] nvme: register ns_id attributes as default sysfs groups · Christoph Hellwig <hch@lst.de> · 2018-07-30
Re: [PATCH 3/6] nvme: register ns_id attributes as default sysfs groups · Bart Van Assche <hidden> · 2018-08-13
Re: [PATCH 3/6] nvme: register ns_id attributes as default sysfs groups · Hannes Reinecke <hare@suse.de> · 2018-08-14
[PATCH 4/6] aoe: use device_add_disk_with_groups() · Hannes Reinecke <hare@suse.de> · 2018-07-30
Re: [PATCH 4/6] aoe: use device_add_disk_with_groups() · Christoph Hellwig <hch@lst.de> · 2018-07-30
Re: [PATCH 4/6] aoe: use device_add_disk_with_groups() · Ed Cashin <hidden> · 2018-08-01
Re: [PATCH 4/6] aoe: use device_add_disk_with_groups() · Hannes Reinecke <hare@suse.de> · 2018-08-01
Re: [PATCH 4/6] aoe: use device_add_disk_with_groups() · Ed Cashin <hidden> · 2018-08-02
[PATCH 5/6] zram: register default groups with device_add_disk() · Hannes Reinecke <hare@suse.de> · 2018-07-30
Re: [PATCH 5/6] zram: register default groups with device_add_disk() · Christoph Hellwig <hch@lst.de> · 2018-07-30
[PATCH 6/6] virtio-blk: modernize sysfs attribute creation · Hannes Reinecke <hare@suse.de> · 2018-07-30
Re: [PATCH 6/6] virtio-blk: modernize sysfs attribute creation · Christoph Hellwig <hch@lst.de> · 2018-07-30
Re: [PATCH 6/6] virtio-blk: modernize sysfs attribute creation · "Michael S. Tsirkin" <mst@redhat.com> · 2018-07-31
Re: [PATCH 6/6] virtio-blk: modernize sysfs attribute creation · Christoph Hellwig <hch@lst.de> · 2018-07-31

From: Christoph Hellwig <hch@lst.de>
Date: 2018-07-30 08:59:06

On Mon, Jul 30, 2018 at 09:12:24AM +0200, Hannes Reinecke wrote:

We should be registering the ns_id attribute as default sysfs
attribute groups, otherwise we have a race condition between
the uevent and the attributes appearing in sysfs.

Signed-off-by: Hannes Reinecke <hare@suse.com>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <redacted>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help