Re: [PATCH v3 0/3] add crc64 calculation as kernel library
From: Coly Li <hidden>
Date: 2018-07-19 02:46:13
Also in:
linux-bcache, lkml
From: Coly Li <hidden>
Date: 2018-07-19 02:46:13
Also in:
linux-bcache, lkml
On 2018/7/17 10:55 PM, Coly Li wrote:
This patch set adds basic implementation of crc64 calculation as Linux
kernel library. Since bcache already does crc64 by itself, this patch
set also modifies bcache code to use the new crc64 library routine.
bcache uses crc64 as storage checksum, if a change of crc lib routines
results an inconsistent result, the unmatched checksum may make bcache
'think' the on-disk is corrupted, such change should be avoided or
detected as early as possible. Therefore the last patch in this series
adds a crc test framework, to check consistency of different calculations.
Changelog:
v3: Remove little endian restriction and remove 'le' from function names.
Fixes all review comments of v2
v2: Combine first two patches into one
Fixes all review comments of v1
v1: Initial version.
Coly LiHi folks, Many thanks for your review and comments, I do appreciate for your help. Also thank Andrew to pick up the patches. Coly Li