Re: [PATCH 2/5] lightnvm: pblk: Remove resv field for sec meta
From: Matias Bjørling <hidden>
Date: 2018-06-16 19:27:31
On 06/16/2018 12:27 AM, Igor Konopko wrote:
quoted hunk ↗ jump to hunk
Since we have flexible size of pblk_sec_meta which depends on drive metadata size we can remove not needed reserved field from that structure Signed-off-by: Igor Konopko <redacted> --- drivers/lightnvm/pblk.h | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/lightnvm/pblk.h b/drivers/lightnvm/pblk.h index f82c3a0b0de5..27658dc6fc1a 100644 --- a/drivers/lightnvm/pblk.h +++ b/drivers/lightnvm/pblk.h@@ -82,7 +82,6 @@ enum { }; struct pblk_sec_meta { - u64 reserved; __le64 lba; };
Looks good to me. Javier may have some comment on this, since it is not completely obvious from the code why that reserved attribute is there. I do like the change to go in, as it needlessly extends the requirement from 8 to 16bytes.