Re: [PATCH blktests 00/15] Add SRP initiator driver tests

On Mon, Jun 25, 2018 at 10:05:41AM -0700, Bart Van Assche wrote:

On 06/22/18 20:15, Ming Lei wrote:

quoted

Just tried srp/001

[root@ktest-04 blktests]# ./check srp/001
srp/001 (Create and remove LUNs)                             [failed]
     runtime  0.912s  ...  18.358s
     --- tests/srp/001.out 2018-06-23 02:41:33.267925950 +0000
     +++ results/nodev/srp/001.out.bad 2018-06-23 03:11:30.062799405 +0000
     @@ -1,8 +1,27 @@
     -Unloaded the ib_srpt kernel module
     +Unloaded the ib_srp kernel module
     +modprobe: FATAL: Module target_core_mod is in use.
     +modprobe: FATAL: Module target_core_mod is in use.
     +modprobe: FATAL: Module target_core_mod is in use.
     +modprobe: FATAL: Module target_core_mod is in use.
     +modprobe: FATAL: Module target_core_mod is in use.
     ...
     (Run 'diff -u tests/srp/001.out results/nodev/srp/001.out.bad' to
see the entire diff)

[root@ktest-04 blktests]# lsmod | grep target
iscsi_target_mod      303104  1 ib_isert
target_core_mod       356352  2 iscsi_target_mod,ib_isert

LIO must be unconfigured before the SRP tests are run. The above output
shows that LIO was already loaded before the SRP tests were started. I will
add a test that prevents the SRP tests to start if LIO was already
configured.

I run SRP test on Fedora 27, and not run any LIO specific commands
to load it, seems it is done automatically.

So looks it might not a good idea to fail SRP test if LIO is loaded,
just wondering why your SRP test can't make the two co-exist?

Thanks,
Ming