Thread (6 messages) 6 messages, 2 authors, 2018-06-28

Re: [PATCH] block: Simplify the bio cloning implementation

From: Bart Van Assche <hidden>
Date: 2018-06-27 23:55:20

On 06/27/18 16:21, Ming Lei wrote:
What we need to do is to only copy the 1st bvec for WRITE_SAME, your patch
changes to copy (bio->bi_iter.bi_size / block size) bvecs, then memory corruption
may be triggered. So bio_for_each_segment() can't be used here.
Has it been considered to use memcpy() to copy the bi_vcnt bio_vecs 
instead of using bio_for_each_segment() in bio_clone_bioset()? That will 
in this context probably be even faster than using bio_for_each_segment().

Bart.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help