Thread (10 messages) 10 messages, 3 authors, 2018-06-07

Re: [PATCH] block: Add block level changes for inline encryption

From: Jens Axboe <axboe@kernel.dk>
Date: 2018-06-07 01:52:59
Also in: lkml

On 6/6/18 1:35 AM, Ladvine D Almeida wrote:
On Friday 01 June 2018 09:13 AM, Christoph Hellwig wrote:
quoted
On Mon, May 28, 2018 at 02:43:09PM +0100, Ladvine D Almeida wrote:
quoted
This patch introduces new variable under bio structure to
facilitate inline encryption. This variable is used to
associate I/O requests to crypto information.
This seems to be missing a whole lot of context.  Where is the whole
series showing what you are trying to do?
Christoph,

The patches are generated in the below > manner, with a thought of
sending separately to the MAINTAINERS responsible for each.
What both Christoph and I have said is that it's _impossible_ to review
changes when you don't know what is being built on top of it. The block
change, by itself, is utterly useless. The use case needs to be seen.
But apart from that, my comments on why it's doing it completely
backwards still apply, and I've outlined how you need to fix it. The
patch, in its current form, isn't going anywhere.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help