[PATCH V7 08/24] block: bio_set_pages_dirty can't see NULL bv_page in a valid bio_vec
flat view
STALE2890d
REVIEWED: 1 (0M)
From: Ming Lei <hidden>
Date: 2018-06-27 12:45:32
Also in:
linux-fsdevel, linux-mm, lkml
Subsystem:
block layer, the rest · Maintainers:
Jens Axboe, Linus Torvalds
Revision v7 of 7 in this series; 1 review trailer.
Revisions (7)
From: Christoph Hellwig <hch@lst.de> So don't bother handling it. Reviewed-by: Ming Lei <redacted> Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/bio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/block/bio.c b/block/bio.c
index 77f991688810..de6cbaedfb65 100644
--- a/block/bio.c
+++ b/block/bio.c@@ -1557,10 +1557,8 @@ void bio_set_pages_dirty(struct bio *bio) int i; bio_for_each_segment_all(bvec, bio, i) { - struct page *page = bvec->bv_page; - - if (page && !PageCompound(page)) - set_page_dirty_lock(page); + if (!PageCompound(bvec->bv_page)) + set_page_dirty_lock(bvec->bv_page); } } EXPORT_SYMBOL_GPL(bio_set_pages_dirty);
--
2.9.5