On 05/31/2018 09:25 AM, Christoph Hellwig wrote:

On Wed, May 30, 2018 at 10:33:49AM -0700, Daniel Verkamp wrote:

quoted

Minor nitpick here: if ctrlr->nr_changed_ns is exactly
NVME_MAX_CHANGED_NAMESPACES and the new nsid is already in the list,
this will skip down to the 0xffffffff case below, even though it could
have just left the list as-is.

I don't know if this is a problem in practice; reporting 0xffffffff is
probably always safe, since the host will presumably treat that as
"rescan everything".

It probably doesn't matter, but it turns doing this propely actually
looks cleaner as well:

---
From d4baf4068220a90ecf67309d01ece5d0aadd952e Mon Sep 17 00:00:00 2001
From: Christoph Hellwig <hch@lst.de>
Date: Fri, 25 May 2018 17:16:09 +0200
Subject: nvmet: implement the changed namespaces log

Agreed, this version looks good to me:
Reviewed-by: Daniel Verkamp <redacted>

Thanks,
-- Daniel