Thread (39 messages) 39 messages, 5 authors, 2018-05-29

Re: [PATCH 07/14] scsi_transport_fc: complete requests from ->timeout

From: Hannes Reinecke <hare@suse.de>
Date: 2018-05-23 13:30:37

On 05/23/2018 02:19 PM, Christoph Hellwig wrote:
quoted hunk ↗ jump to hunk
By completing the request entirely in the driver we can remove the
BLK_EH_HANDLED return value and thus the split responsibility between the
driver and the block layer that has been causing trouble.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
  drivers/scsi/scsi_transport_fc.c | 7 +++----
  1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
index 90075a0ddcfe..7a9a65588a1b 100644
--- a/drivers/scsi/scsi_transport_fc.c
+++ b/drivers/scsi/scsi_transport_fc.c
@@ -3591,10 +3591,9 @@ fc_bsg_job_timeout(struct request *req)
  	}
  
  	/* the blk_end_sync_io() doesn't check the error */
-	if (!inflight)
-		return BLK_EH_DONE;
-	else
-		return BLK_EH_HANDLED;
+	if (inflight)
+		blk_mq_complete_request(req);
+	return BLK_EH_DONE;
  }
  
  /**
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help