Re: [PATCH 1/3] blk-mq: Allow PCI vector offset for mapping queues
From: Keith Busch <hidden>
Date: 2018-03-26 19:37:49
Also in:
linux-nvme
From: Keith Busch <hidden>
Date: 2018-03-26 19:37:49
Also in:
linux-nvme
On Mon, Mar 26, 2018 at 09:50:38AM +0800, Ming Lei wrote:
Given no many callers of blk_mq_pci_map_queues(), I suggest to add the parameter of 'offset' to this API directly, then people may keep the '.pre_vectors' stuff in mind, and avoid to misuse it.
Yeah, I think I have to agree. I was trying really hard to not touch other drivers, but the concept doesn't seem odd enough to justify hiding it behind a default parameter. I'll send v2 tomorrow if there's no other feedback.