Re: [PATCH V4 3/4] scsi: introduce force_blk_mq
From: Christoph Hellwig <hch@lst.de>
Date: 2018-03-10 10:10:42
On Fri, Mar 09, 2018 at 11:32:17AM +0800, Ming Lei wrote:
quoted hunk ↗ jump to hunk
quoted
From scsi driver view, it is a bit troublesome to support both blk-mqand non-blk-mq at the same time, especially when drivers need to support multi hw-queue. This patch introduces 'force_blk_mq' to scsi_host_template so that drivers can provide blk-mq only support, so driver code can avoid the trouble for supporting both. Cc: Omar Sandoval <redacted>, Cc: "Martin K. Petersen" <martin.petersen@oracle.com>, Cc: James Bottomley <james.bottomley@hansenpartnership.com>, Cc: Christoph Hellwig <hch@lst.de>, Cc: Don Brace <redacted> Cc: Kashyap Desai <kashyap.desai@broadcom.com> Cc: Mike Snitzer <redacted> Cc: Laurence Oberman <redacted> Reviewed-by: Hannes Reinecke <hare@suse.de> Signed-off-by: Ming Lei <redacted> --- drivers/scsi/hosts.c | 1 + include/scsi/scsi_host.h | 3 +++ 2 files changed, 4 insertions(+)diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c index 57bf43e34863..10f04b089392 100644 --- a/drivers/scsi/hosts.c +++ b/drivers/scsi/hosts.c@@ -477,6 +477,7 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize) shost->dma_boundary = 0xffffffff; shost->use_blk_mq = scsi_use_blk_mq; + shost->use_blk_mq = scsi_use_blk_mq || !!shost->hostt->force_blk_mq;
No need for the !! here. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>