Thread (7 messages) 7 messages, 3 authors, 2018-03-14

Re: [PATCH v2] block: bio_check_eod() needs to consider partition

From: Jens Axboe <axboe@kernel.dk>
Date: 2018-03-13 17:37:05

On 3/13/18 9:25 AM, Bart Van Assche wrote:
On Tue, 2018-03-13 at 07:49 -0700, Jens Axboe wrote:
quoted
On 3/13/18 2:18 AM, Christoph Hellwig wrote:
quoted
bio_check_eod() should check partiton size not the whole disk if
bio->bi_partno is non-zero.  Does this by taking the call to bio_check_eod
into blk_partition_remap.
Applied, thanks.
Hello Christoph and Jens,

I think that this patch introduces a severe regression: with this patch applied
a VM that I use for kernel testing doesn't boot anymore. If I revert this patch
that VM boots fine again. This is what I see on the serial console with this
patch applied:

virtio_blk virtio4: [vda] 41943040 512-byte logical blocks (21.5 GB/20.0 GiB)
 vda: vda1
attempt to access beyond end of device
vda: rw=0, want=41940872, limit=41938944
attempt to access beyond end of device
vda: rw=0, want=41940872, limit=41938944
I've killed the patch for now, thanks for the quick test, Bart.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help