Re: [PATCH v2 02/11] block: sed-opal: unify space check in add_token_*

[PATCH 0/8] block: sed-opal: support write to shadow mbr · Jonas Rabenstein <hidden> · 2018-03-13
[PATCH 1/8] block: sed-opal: use correct macro for method length · Jonas Rabenstein <hidden> · 2018-03-13
[PATCH 2/8] block: sed-opal: unify space check in add_token_* · Jonas Rabenstein <hidden> · 2018-03-13
[PATCH 3/8] block: sed-opal: unify cmd start and finalize · Jonas Rabenstein <hidden> · 2018-03-13
Re: [PATCH 3/8] block: sed-opal: unify cmd start and finalize · Scott Bauer <hidden> · 2018-03-13
[PATCH v2 3/8] block: sed-opal: unify cmd start and finalize · Jonas Rabenstein <hidden> · 2018-03-14
[PATCH 4/8] block: sed-opal: unify error handling of responses · Jonas Rabenstein <hidden> · 2018-03-13
[PATCH 6/8] block: sed-opal: split generation of bytestring header and content · Jonas Rabenstein <hidden> · 2018-03-13
[PATCH 7/8] block: sed-opal: add ioctl for done-mark of shadow mbr · Jonas Rabenstein <hidden> · 2018-03-13
[PATCH 8/8] block: sed-opal: ioctl for writing to shadow mbr · Jonas Rabenstein <hidden> · 2018-03-13
Re: [PATCH 8/8] block: sed-opal: ioctl for writing to shadow mbr · Scott Bauer <hidden> · 2018-03-13
[PATCH v2 8.0/8.4] block: sed-opal: check size of shadow mbr · Jonas Rabenstein <hidden> · 2018-03-14
[PATCH v2 8.1/8.4] block: sed-opal: ioctl for writing to shadow mbr · Jonas Rabenstein <hidden> · 2018-03-14
[PATCH v2 8.2/8.4] block: sed-opal: unify retrieval of table columns · Jonas Rabenstein <hidden> · 2018-03-14
[PATCH v2 8.3/8.4] block: sed-opal: get metadata about opal-sed tables · Jonas Rabenstein <hidden> · 2018-03-14
[PATCH v2 8.4/8.4] block: sed-opal: check size of shadow mbr · Jonas Rabenstein <hidden> · 2018-03-14
Re: [PATCH 8/8] block: sed-opal: ioctl for writing to shadow mbr · kbuild test robot <hidden> · 2018-03-14
[PATCH 5/8] block: sed-opal: print failed function address · Jonas Rabenstein <hidden> · 2018-03-13
Re: [PATCH 0/8] block: sed-opal: support write to shadow mbr · Scott Bauer <hidden> · 2018-03-13
[PATCH v2 00/11] block: sed-opal support write to shadow mbr · Jonas Rabenstein <hidden> · 2018-03-19
[PATCH v2 01/11] block: sed-opal: use correct macro for method length · Jonas Rabenstein <hidden> · 2018-03-19
Re: [PATCH v2 01/11] block: sed-opal: use correct macro for method length · Christoph Hellwig <hch@lst.de> · 2018-03-19
[PATCH v2 03/11] block: sed-opal: unify cmd start and finalize · Jonas Rabenstein <hidden> · 2018-03-19
Re: [PATCH v2 03/11] block: sed-opal: unify cmd start and finalize · Christoph Hellwig <hch@lst.de> · 2018-03-19
[PATCH v2 04/11] block: sed-opal: unify error handling of responses · Jonas Rabenstein <hidden> · 2018-03-19
Re: [PATCH v2 04/11] block: sed-opal: unify error handling of responses · Christoph Hellwig <hch@lst.de> · 2018-03-19
[PATCH v2 05/11] block: sed-opal: print failed function address · Jonas Rabenstein <hidden> · 2018-03-19
Re: [PATCH v2 05/11] block: sed-opal: print failed function address · Christoph Hellwig <hch@lst.de> · 2018-03-19
[PATCH v2 06/11] block: sed-opal: split generation of bytestring header and content · Jonas Rabenstein <hidden> · 2018-03-19
Re: [PATCH v2 06/11] block: sed-opal: split generation of bytestring header and content · Christoph Hellwig <hch@lst.de> · 2018-03-19
Re: [PATCH v2 06/11] block: sed-opal: split generation of bytestring header and content · Scott Bauer <hidden> · 2018-03-19
[PATCH v2 09/11] block: sed-opal: unify retrieval of table columns · Jonas Rabenstein <hidden> · 2018-03-19
[PATCH v2 10/11] block: sed-opal: get metadata about opal-sed tables · Jonas Rabenstein <hidden> · 2018-03-19
Re: [PATCH v2 10/11] block: sed-opal: get metadata about opal-sed tables · Christoph Hellwig <hch@lst.de> · 2018-03-19
[PATCH v2 11/11] block: sed-opal: check size of shadow mbr · Jonas Rabenstein <hidden> · 2018-03-19
Re: [PATCH v2 11/11] block: sed-opal: check size of shadow mbr · Christoph Hellwig <hch@lst.de> · 2018-03-19
Re: [PATCH v2 11/11] block: sed-opal: check size of shadow mbr · Jonas Rabenstein <hidden> · 2018-03-20
[PATCH v2 08/11] block: sed-opal: ioctl for writing to shadow mbr · Jonas Rabenstein <hidden> · 2018-03-19
Re: [PATCH v2 08/11] block: sed-opal: ioctl for writing to shadow mbr · Christoph Hellwig <hch@lst.de> · 2018-03-19
Re: [PATCH v2 08/11] block: sed-opal: ioctl for writing to shadow mbr · Jonas Rabenstein <hidden> · 2018-03-20
Re: [PATCH v2 08/11] block: sed-opal: ioctl for writing to shadow mbr · Scott Bauer <hidden> · 2018-03-20
Re: [PATCH v2 08/11] block: sed-opal: ioctl for writing to shadow mbr · Jonas Rabenstein <hidden> · 2018-03-21
Re: [PATCH v2 08/11] block: sed-opal: ioctl for writing to shadow mbr · Jonas Rabenstein <hidden> · 2018-03-29
Re: [PATCH v2 08/11] block: sed-opal: ioctl for writing to shadow mbr · Scott Bauer <hidden> · 2018-03-29
Re: [PATCH v2 08/11] block: sed-opal: ioctl for writing to shadow mbr · <hidden> · 2018-03-29
Re: [PATCH v2 08/11] block: sed-opal: ioctl for writing to shadow mbr · Scott Bauer <hidden> · 2018-04-05
[PATCH v2 07/11] block: sed-opal: add ioctl for done-mark of shadow mbr · Jonas Rabenstein <hidden> · 2018-03-19
Re: [PATCH v2 07/11] block: sed-opal: add ioctl for done-mark of shadow mbr · Christoph Hellwig <hch@lst.de> · 2018-03-19
[PATCH v2 02/11] block: sed-opal: unify space check in add_token_* · Jonas Rabenstein <hidden> · 2018-03-19
Re: [PATCH v2 02/11] block: sed-opal: unify space check in add_token_* · Christoph Hellwig <hch@lst.de> · 2018-03-19
Re: [PATCH v2 00/11] block: sed-opal support write to shadow mbr · Christoph Hellwig <hch@lst.de> · 2018-03-19
Re: [PATCH v2 00/11] block: sed-opal support write to shadow mbr · Scott Bauer <hidden> · 2018-03-19

From: Christoph Hellwig <hch@lst.de>
Date: 2018-03-19 19:54:26
Also in: lkml

On Mon, Mar 19, 2018 at 07:36:44PM +0100, Jonas Rabenstein wrote:

All add_token_* functions have a common set of conditions that have to
be checked. Use a common function for those checks in order to avoid
different behaviour as well as code duplication.

Signed-off-by: Jonas Rabenstein <redacted>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help