Thread (4 messages) 4 messages, 4 authors, 2018-02-23

Re: [PATCH V2] block: pass inclusive 'lend' parameter to truncate_inode_pages_range

From: Ming Lei <tom.leiming@gmail.com>
Date: 2018-02-22 03:23:20
Also in: stable

On Sat, Feb 10, 2018 at 8:46 AM, Ming Lei [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The 'lend' parameter of truncate_inode_pages_range is required to be
inclusive, so follow the rule.

This patch fixes one memory corruption triggered by discard.

Cc: <redacted>
Cc: Dmitry Monakhov <redacted>
Fixes: 351499a172c0 ("block: Invalidate cache on discard v2")
Signed-off-by: Ming Lei <redacted>
---
V2:
        - Cc stable list and Dmitry as suggested by Bart

 block/ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/ioctl.c b/block/ioctl.c
index 1668506d8ed8..3884d810efd2 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -225,7 +225,7 @@ static int blk_ioctl_discard(struct block_device *bdev, fmode_t mode,

        if (start + len > i_size_read(bdev->bd_inode))
                return -EINVAL;
-       truncate_inode_pages_range(mapping, start, start + len);
+       truncate_inode_pages_range(mapping, start, start + len - 1);
        return blkdev_issue_discard(bdev, start >> 9, len >> 9,
                                    GFP_KERNEL, flags);
 }
--
2.9.5
Hi Jens,

Could you consider it in v4.16 since it does fix a regression in lkp test?

Thanks,
Ming Lei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help