On 30/01/2018 10:33, John Garry wrote:

On 30/01/2018 01:24, Ming Lei wrote:

quoted

On Mon, Jan 29, 2018 at 12:56:30PM -0800, James Bottomley wrote:

quoted

On Mon, 2018-01-29 at 23:46 +0800, Ming Lei wrote:
[...]

quoted

2. When to enable SCSI_MQ at default again?

I'm not sure there's much to discuss ... I think the basic answer is as
soon as Christoph wants to try it again.

I guess Christoph still need to evaluate if there are existed issues or
blockers before trying it again. And more input may be got from F2F
discussion, IMHO.

quoted

quoted

SCSI_MQ is enabled on V3.17 firstly, but disabled at default. In
V4.13-rc1, it is enabled at default, but later the patch is reverted
in V4.13-rc7, and becomes disabled at default too.

Now both the original reported PM issue(actually SCSI quiesce) and
the sequential IO performance issue have been addressed.

Is the blocker bug just not closed because no-one thought to do it:

https://bugzilla.kernel.org/show_bug.cgi?id=178381

(we have confirmed that this issue is now fixed with the original
reporter?)

quoted

From a developer view, this issue is fixed by the following commit:

3a0a52997(block, scsi: Make SCSI quiesce and resume work reliably),
and it is verified by kernel list reporter.

quoted

And did the Huawei guy (Jonathan Cameron) confirm his performance issue
was fixed (I don't think I saw email that he did)?

Last time I talked with John Garry about the issue, and the merged
.get_budget
based patch improves much on the IO performance, but there is still a
bit gap
compared with legacy path. Seems a driver specific issue, remembered
that removing
a driver's lock can improve performance much.

Garry, could you provide further update on this issue?

Hi Ming,

From our testing with experimental changes to our driver to support SCSI
mq we were almost getting on par performance with legacy path. But
without these MQ was hitting performance (and I would not necessarily
say it was a driver issue).

We can retest from today's mainline and see where we are.

BTW, Have you got performance figures for many other single queue HBAs
with and without CONFIG_SCSI_MQ_DEFAULT=Y?

We finally got around to retesting this (on hisi_sas controller). So the 
results are generally ok, in that we are now not seeing such big 
performance drops in our hardware for enabling SCSI MQ - in some 
scenarios the performance is better. Generally fio rw mode is better.

Anyway, for what it's worth, it's a green light from us to set SCSI MQ 
on by default.

John

Thanks,
John

quoted

Thanks,
Ming

.

_______________________________________________
Linuxarm mailing list
Linuxarm@huawei.com
http://hulk.huawei.com/mailman/listinfo/linuxarm

.