Thread (28 messages) 28 messages, 2 authors, 2018-02-21

Re: [PATCH v2] blk-mq: Fix race between resetting the timer and completion handling

From: "tj@kernel.org" <tj@kernel.org>
Date: 2018-02-08 17:54:51

On Thu, Feb 08, 2018 at 05:48:32PM +0000, Bart Van Assche wrote:
On Thu, 2018-02-08 at 09:40 -0800, tj@kernel.org wrote:
quoted
Heh, sorry about not being clear.  What I'm trying to say is that
scmd->device != NULL && device->host == NULL.  Or was this what you
were saying all along?
What I agree with is that the request pointer (req argument) is stored in %rdi
and that mov 0x1b0(%rdi),%rax loads scmd->device into %rax. Since RIP ==
scsi_times_out+0x17, since the instruction at that address tries to dereference
%rax and since the register dump shows that %rax == NULL I think that means that
scmd->device == NULL.
Ah, I was completely confused about which one had to be NULL.  You're
absolutely right.  Let's continue earlier in the thread.

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help