Thread (11 messages) 11 messages, 3 authors, 2018-02-27

Re: [PATCH 1/6] genhd: Fix leaked module reference for NVME devices

From: Christoph Hellwig <hch@lst.de>
Date: 2018-02-27 00:09:48

On Mon, Feb 26, 2018 at 01:01:37PM +0100, Jan Kara wrote:
Commit 8ddcd653257c "block: introduce GENHD_FL_HIDDEN" added handling of
hidden devices to get_gendisk() but forgot to drop module reference
which is also acquired by get_disk(). Drop the reference as necessary.

Arguably the function naming here is misleading as put_disk() is *not*
the counterpart of get_disk() but let's fix that in the follow up
commit since that will be more intrusive.
Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help