Re: [PATCH] lightnvm: Avoid validation of default op value Avoid validation of default op value, if default value is given. In preparation of using the rsvd field of the extended config for additional paramters while using default op.
From: Javier Gonzalez <hidden>
Date: 2018-02-26 19:58:19
quoted hunk ↗ jump to hunk
On 26 Feb 2018, at 20.45, Heiner Litz [off-list ref] wrote: Fixes: 38401d231de65 ("lightnvm: set target over-provision on create ioctl") Signed-off-by: Heiner Litz <redacted> --- drivers/lightnvm/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index dcc9e621e651..4e6095e2af06 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c@@ -304,10 +304,9 @@ static int __nvm_config_extended(struct nvm_dev *dev,} /* op not set falls into target's default */ - if (e->op == 0xFFFF) + if (e->op == 0xFFFF) { e->op = NVM_TARGET_DEFAULT_OP; - - if (e->op < NVM_TARGET_MIN_OP || + } else if (e->op < NVM_TARGET_MIN_OP || e->op > NVM_TARGET_MAX_OP) {
While you are at it, can you fix this and put it in a single line - not sure why this ended up this way...
pr_err("nvm: invalid over provisioning value\n");
return -EINVAL;
--
2.14.1Apart from the comment, the patch looks good. However, the description went over to the subject. I guess Matias can fix this when picking it up. Reviewed-by: Javier González <redacted>
Attachments
- signature.asc [application/pgp-signature] 833 bytes