Thread (12 messages) 12 messages, 2 authors, 2017-12-13

Re: [PATCH 6/6] nvme: remove .init_request callback

From: Christoph Hellwig <hch@lst.de>
Date: 2017-12-12 14:14:00
Also in: linux-nvme

On Tue, Dec 12, 2017 at 07:02:32PM +0800, Ming Lei wrote:
It may cause race by setting 'nvmeq' in nvme_init_request()
because .init_request is called inside switching io scheduler, which
may happen when the NVMe device is being resetted and its nvme queues
are being freed and created. We don't have any sync between the two
pathes.

This patch removes the .init_request callback and sets the nvmeq runtime,
and fixes the following bug:
If ->init_request doesn't work for NVMe it won't work for any other
driver either, so we need to remove it entirely if we can't fix it.

I'd much rather try to fix it first, though.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help