Thread (10 messages) flat view 10 messages, 4 authors, 2017-12-13

Re: [PATCH] locking/lockdep: Add CONFIG_LOCKDEP_AGGRESSIVE

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2017-12-12 17:00:57
Also in: linux-fsdevel

On Mon, Dec 11, 2017 at 9:20 PM, Byungchul Park [off-list ref] wrote:
The *problem* is false positives, since locks and waiters in
kernel are not classified properly
So the problem is that those false positives apparently end up being a
big deal for the filesystem people.

I personally don't think the code itself has to be removed, but I do
think that it should never have been added on as part of the generic
lock proving, and should always have been a separate config option.

I also feel that you dismiss "false positives" much too easily. A
false positive is a big problem - because it makes people ignore the
real cases (or just disable the functionality entirely).

It's why I am very quick to disable compiler warnings that have false
positives, for example. Just a couple of "harmless" false positive
warnings will poison the real warnings for people because they'll get
used to seeing warnings while building, and no longer actually look at
them.

                 Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help