Thread (2 messages) 2 messages, 2 authors, 2017-11-14

Re: [PATCH] blkcg: correctly update stat

From: Tejun Heo <tj@kernel.org>
Date: 2017-11-14 21:03:26

On Tue, Nov 14, 2017 at 10:05:07AM -0800, Shaohua Li wrote:
blkcg_bio_issue_check() checks throtl for stat update, which isn't good
because the bio could be splitted into small bios, the samll bios go
into blkcg_bio_issue_check again and we update stat for the small bios,
so we the stat is double charged. To fix this, we only update stat if
the bio doesn't have BIO_THROTTLED flag. The fix will update stat ahead
of bio skips from blk-throttle, but eventually the stat is correct.

This patch is on top of patch:
https://marc.info/?l=linux-block&m=151060860608914&w=2

Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Shaohua Li <redacted>
Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help