Thread (2 messages) 2 messages, 2 authors, 2017-11-28

[PATCH] block: Add default switch case to blk_pm_allow_request() to kill warning

flat view
STALE3235d

From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: 2017-11-27 20:41:00
Also in: lkml
Subsystem: block layer, the rest · Maintainers: Jens Axboe, Linus Torvalds

With gcc 4.9.0:

    block/blk-core.c: In function 'blk_pm_allow_request':
    block/blk-core.c:2607:2: warning: enumeration value 'RPM_ACTIVE' not handled in switch [-Wswitch]
      switch (rq->q->rpm_status) {
      ^

Convert the return statement below the switch() block into a default
case to fix this.

Fixes: e4f36b249b4d4e75 ("block: fix peeking requests during PM")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 block/blk-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index b8881750a3acd705..579e683c95e26049 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -2610,9 +2610,9 @@ static bool blk_pm_allow_request(struct request *rq)
 		return rq->rq_flags & RQF_PM;
 	case RPM_SUSPENDED:
 		return false;
+	default:
+		return true;
 	}
-
-	return true;
 }
 #else
 static bool blk_pm_allow_request(struct request *rq)
-- 
2.7.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help