Re: [PATCH V13 08/10] mmc: block: blk-mq: Separate card polling from recovery
From: Adrian Hunter <adrian.hunter@intel.com>
Date: 2017-11-09 07:56:47
Also in:
linux-mmc, lkml
On 08/11/17 11:30, Linus Walleij wrote:
On Fri, Nov 3, 2017 at 2:20 PM, Adrian Hunter [off-list ref] wrote:quoted
Recovery is simpler to understand if it is only used for errors. Create a separate function for card polling. Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>This looks good but I can't see why it's not folded into patch 3 already. This error handling is introduced there.
What are you on about? If we're going to split up the patches (which I argued against - the new code is all new, so it could be read independently from the old mess) then this is a logically distinct step. Polling and error-recovery are conceptually different things and it is important to separate them to make the code easier to understand.