Re: [PATCH 07/11] xfs: remove not needed freezing calls

On Friday, December 1, 2017 12:30:33 AM CET Dave Chinner wrote:

On Thu, Nov 30, 2017 at 09:32:53PM +0100, Rafael J. Wysocki wrote:

quoted

On Thu, Nov 30, 2017 at 5:21 PM, Jan Kara [off-list ref] wrote:

quoted

On Wed 29-11-17 15:23:52, Luis R. Rodriguez wrote:

quoted

This removes superflous freezer calls as they are no longer needed
as the VFS now performs filesystem freezing/thaw if the filesystem has
support for it.

The following Coccinelle rule was used as follows:

spatch --sp-file fs-freeze-cleanup.cocci --in-place fs/$FS/

I think your rule misses WQ_FREEZABLE flag for workqueues? That would be
also good to get rid of...

We need that one (or equivalent) for the runtime PM workqueue at least.

I think Jan was talking about all the WQ_FREEZABLE flags in
filesystem workqueues (such as all the XFS wqs) that are no longer
necessary once filesystems are frozen appropriately.

I see, thanks.  That was unclear to me, sorry for the confusion.

Thanks,
Rafael