Re: [PATCH v2] virtio_blk: Fix an SG_IO regression
From: Jens Axboe <axboe@kernel.dk>
Date: 2017-10-25 18:23:28
Also in:
stable
On 10/25/2017 02:56 AM, Bart Van Assche wrote:
Avoid that submitting an SG_IO ioctl triggers a kernel oops that is preceded by: usercopy: kernel memory overwrite attempt detected to (null) (<null>) (6 bytes) kernel BUG at mm/usercopy.c:72!
Seems I saw a note on a runtime oops triggered by this patch yesterday, but now I can't seem to find it... Did you see it?
quoted hunk ↗ jump to hunk
diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig index 4a438b8abe27..b0b2100763bf 100644 --- a/drivers/block/Kconfig +++ b/drivers/block/Kconfig@@ -450,6 +450,7 @@ config VIRTIO_BLK_SCSI bool "SCSI passthrough request for the Virtio block driver" depends on VIRTIO_BLK select BLK_SCSI_REQUEST + select SCSI_MOD
Should this be SCSI? That's what libata does. It may be correct as-is, didn't look too deeply, just curious why it's different. -- Jens Axboe