Thread (28 messages) 28 messages, 5 authors, 2017-11-01

Re: [PATCH v2 6/8] scsi/ipr: Use sgl_alloc_order() and sgl_free_order()

From: Brian King <hidden>
Date: 2017-10-30 21:01:48
Also in: linux-crypto, linux-nvme, linux-scsi

On 10/30/2017 03:37 PM, Bart Van Assche wrote:
On Wed, 2017-10-18 at 15:57 -0500, Brian King wrote:
quoted
On 10/17/2017 01:19 AM, Hannes Reinecke wrote:
quoted
On 10/17/2017 12:49 AM, Bart Van Assche wrote:
quoted
[ ... ]
Not sure if this is a valid conversion.
Originally the driver would allocate a single buffer; with this buffer
we have two distinct buffers.
Given that this is used to download the microcode I'm not sure if this
isn't a hardware-dependent structure which requires a single buffer
including the sglist.
Brian, can you shed some light here?
The struct ipr_sglist is not a hardware defined data structure, so on initial
glance, this should be OK. I'll load it up and give it a try to make sure
it doesn't break code download.
Hello Brian,

Have you already obtained any test results?
Bart,

Yes. I tried this out on an ipr adapter and it looks fine.

Acked-by: Brian King <redacted>

Thanks,

Brian

-- 
Brian King
Power Linux I/O
IBM Linux Technology Center
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help