On Tue, Oct 24, 2017 at 6:21 PM,  [off-list ref] wrote:

quoted

quoted

static void bch_btree_gc_finish(struct cache_set *c)

available should be removed and this function should return 0.

I have changed this function to a void type, so nothing need return.

Sorry, I misread that. :)

quoted

quoted

+             stats.in_use            = (c->nbuckets - c->avail_nbuckets) * 100 / c->nbuckets;

This should instead call bch_update_bucket_in_use to avoid code duplication.

OK, I will modify it and resend a v2 patch later.

OK, that's my only complaint.  Will be glad to add v2 to my staging tree.

quoted

Overall I think this is a good piece of progress.

Thanks for your review and comments again.

Tang Junhui

Thanks!

Mike