[PATCH v5 3/9] completion: Change the prefix of lock name for completion variable
flat view
STALE3272d
From: Byungchul Park <hidden>
Date: 2017-10-25 08:55:59
Also in:
linux-fsdevel, linux-mm, linux-xfs, lkml
Subsystem:
the rest · Maintainer:
Linus Torvalds
Revision v5 of 3 in this series.
Revisions (3)
- v3 [diff vs current]
- v4 [diff vs current]
- v5 current
CONFIG_LOCKDEP_COMPLETIONS uses "(complete)" as a prefix of lock name for completion variable. However, "complete" is a verb or adjective and lock symbol names should be nouns. Use "(completion)" instead, for normal completions. Suggested-by: Ingo Molnar <mingo@kernel.org> Signed-off-by: Byungchul Park <redacted> --- include/linux/completion.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/completion.h b/include/linux/completion.h
index cae5400..9121803 100644
--- a/include/linux/completion.h
+++ b/include/linux/completion.h@@ -53,7 +53,7 @@ static inline void complete_release_commit(struct completion *x) do { \ static struct lock_class_key __key; \ lockdep_init_map_crosslock((struct lockdep_map *)&(x)->map, \ - "(complete)" #x, \ + "(completion)" #x, \ &__key, 0); \ __init_completion(x); \ } while (0)
@@ -67,7 +67,7 @@ static inline void complete_release_commit(struct completion *x) {} #ifdef CONFIG_LOCKDEP_COMPLETIONS #define COMPLETION_INITIALIZER(work) \ { 0, __WAIT_QUEUE_HEAD_INITIALIZER((work).wait), \ - STATIC_CROSS_LOCKDEP_MAP_INIT("(complete)" #work, &(work)) } + STATIC_CROSS_LOCKDEP_MAP_INIT("(completion)" #work, &(work)) } #else #define COMPLETION_INITIALIZER(work) \ { 0, __WAIT_QUEUE_HEAD_INITIALIZER((work).wait) }
--
1.9.1