Thread (1 message) 1 message, 1 author, 2017-09-20

Re: [PATCH] loop: remove union of use_aio and ref in struct loop_cmd

From: Jens Axboe <axboe@kernel.dk>
Date: 2017-09-20 21:27:51

On 09/20/2017 03:24 PM, Omar Sandoval wrote:
From: Omar Sandoval <redacted>

When the request is completed, lo_complete_rq() checks cmd->use_aio.
However, if this is in fact an aio request, cmd->use_aio will have
already been reused as cmd->ref by lo_rw_aio*. Fix it by not using a
union. On x86_64, there's a hole after the union anyways, so this
doesn't make struct loop_cmd any bigger.
Thanks Omar, applied.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help