On 25/09/17 05:39, Bough Chen wrote:

quoted

+static void cqhci_set_irqs(struct cqhci_host *cq_host, u32 set) {
+	u32 ier;
+
+	ier = cqhci_readl(cq_host, CQHCI_ISTE);
+	ier |= set;

I think operation ' |= ' is not correct, since we will also call cqhci_set_irqs(cq_host, 0),
Which means to mask all cmdq irq,  so I think better to directly write the parameter
 'set' to ISTE and ISGE.

True.  I will send a V10 of this patch.