Thread (9 messages) 9 messages, 2 authors, 2017-08-16

Re: [PATCH] blktrace: Fix potentail deadlock between delete & sysfs ops

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2017-08-16 18:17:53
Also in: linux-fsdevel, lkml

On Wed, 16 Aug 2017 14:14:36 -0400
Waiman Long [off-list ref] wrote:
quoted
You also just turned the mutex into a spinlock. What happens if we just
preempted the owner of bdev->bd_mutex and are an RT task with higher
priority? This will turn into a live lock.
 
quoted
+		schedule();
+	}
   
That is OK because I used schedule() instead of cpu_relax() for
inserting delay.
Please explain to me how that is OK? schedule is a nop if the current
task is the highest priority task running, and it preempted the owner
of the lock. Nothing will actually schedule.

-- Steve
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help