Re: [PATCH 8/8] xen-blockfront: quiesce IO before device removal
From: Ming Lei <hidden>
Date: 2017-07-04 22:19:12
Also in:
linux-nvme
On Tue, Jul 04, 2017 at 10:55:12AM +0300, Sagi Grimberg wrote:
quoted hunk ↗ jump to hunk
Before calling blk_cleanup_queue one must make sure that no request is being queued. In order to guarantee that we need to use blk_mq_quiesce as it respects the submission path rcu grace. Cc: Konrad Rzeszutek Wilk <redacted> Cc: Roger Pau Monn� <roger.pau@citrix.com> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> Cc: Juergen Gross <jgross@suse.com> Signed-off-by: Sagi Grimberg <sagi@grimberg.me> --- drivers/block/xen-blkfront.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index c852ed3c01d5..5272ca8fb0dc 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c@@ -1187,7 +1187,7 @@ static void xlvbd_release_gendisk(struct blkfront_info *info) return; /* No more blkif_request(). */ - blk_mq_stop_hw_queues(info->rq); + blk_mq_quiesce_queue(info->rq); for (i = 0; i < info->nr_rings; i++) { struct blkfront_ring_info *rinfo = &info->rinfo[i];@@ -1217,7 +1217,7 @@ static void xlvbd_release_gendisk(struct blkfront_info *info) static inline void kick_pending_request_queues_locked(struct blkfront_ring_info *rinfo) { if (!RING_FULL(&rinfo->ring)) - blk_mq_start_stopped_hw_queues(rinfo->dev_info->rq, true); + blk_mq_unquiesce_queue(rinfo->dev_info->rq); }
Looks the above change isn't needed since this blk_mq_start_stopped_hw_queues() should have been the counterpart of blk_mq_stop_hw_queue() in blkif_queue_rq(). -- Ming