Thread (4 messages) 4 messages, 3 authors, 2017-07-26

Re: [PATCH] brd: fix brd_rw_page() vs copy_to_brd_setup errors

From: Christoph Hellwig <hch@infradead.org>
Date: 2017-07-26 20:12:28

On Tue, Jul 25, 2017 at 06:02:29PM -0700, Dan Williams wrote:
As is done in zram_rw_page, pmem_rw_page, and btt_rw_page, don't
call page_endio in the error case since do_mpage_readpage and
__mpage_writepage will resubmit on error. Calling page_endio in the
error case leads to double completion.

Cc: Jens Axboe <axboe@kernel.dk>
Cc: Matthew Wilcox <redacted>
Cc: Ross Zwisler <redacted>
Signed-off-by: Dan Williams <redacted>
---
Noticed this while looking at unrelated brd code...
And the real question would be:  where would we see any real life impact
of just removing brd_rw_page?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help