Re: [PATCH v2 6/6] nfsd: Check queue type before submitting a SCSI request
From: J . Bruce Fields <hidden>
Date: 2017-06-01 13:29:28
Also in:
linux-nfs
Feel free to add Acked-by: J. Bruce Fields [off-list ref] if you need it.--b. On Wed, May 31, 2017 at 02:43:50PM -0700, Bart Van Assche wrote:
quoted hunk ↗ jump to hunk
Since using scsi_req() is only allowed against request queues for which struct scsi_request is the first member of their private request data, refuse to submit SCSI commands against a queue for which this is not the case. References: commit 82ed4db499b8 ("block: split scsi_request out of struct request") Signed-off-by: Bart Van Assche <redacted> Reviewed-by: Hannes Reinecke <hare@suse.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Cc: J. Bruce Fields <redacted> Cc: Jeff Layton <redacted> Cc: Omar Sandoval <redacted> Cc: linux-nfs@vger.kernel.org --- fs/nfsd/blocklayout.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/fs/nfsd/blocklayout.c b/fs/nfsd/blocklayout.c index fb5213afc854..47ed19c53f2e 100644 --- a/fs/nfsd/blocklayout.c +++ b/fs/nfsd/blocklayout.c@@ -219,6 +219,9 @@ static int nfsd4_scsi_identify_device(struct block_device *bdev, u8 *buf, *d, type, assoc; int error; + if (WARN_ON_ONCE(!blk_queue_scsi_passthrough(q))) + return -EINVAL; + buf = kzalloc(bufflen, GFP_KERNEL); if (!buf) return -ENOMEM;-- 2.12.2