Re: [PATCH rfc 03/30] nvme-rdma: reuse configure/destroy admin queue

[PATCH rfc 00/30] centralize nvme controller reset, delete and periodic reconnects · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
[PATCH rfc 02/30] nvme-rdma: Don't alloc/free the tagset on reset · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 02/30] nvme-rdma: Don't alloc/free the tagset on reset · Christoph Hellwig <hch@lst.de> · 2017-06-19
Re: [PATCH rfc 02/30] nvme-rdma: Don't alloc/free the tagset on reset · Sagi Grimberg <sagi@grimberg.me> · 2017-06-19
Re: [PATCH rfc 02/30] nvme-rdma: Don't alloc/free the tagset on reset · Christoph Hellwig <hch@lst.de> · 2017-06-19
Re: [PATCH rfc 02/30] nvme-rdma: Don't alloc/free the tagset on reset · James Smart <hidden> · 2017-07-10
[PATCH rfc 01/30] nvme: Add admin connect request queue · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 01/30] nvme: Add admin connect request queue · Christoph Hellwig <hch@lst.de> · 2017-06-19
Re: [PATCH rfc 01/30] nvme: Add admin connect request queue · Sagi Grimberg <sagi@grimberg.me> · 2017-06-19
Re: [PATCH rfc 01/30] nvme: Add admin connect request queue · Christoph Hellwig <hch@lst.de> · 2017-06-19
Re: [PATCH rfc 01/30] nvme: Add admin connect request queue · Hannes Reinecke <hare@suse.de> · 2017-06-19
[PATCH rfc 03/30] nvme-rdma: reuse configure/destroy admin queue · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 03/30] nvme-rdma: reuse configure/destroy admin queue · Christoph Hellwig <hch@lst.de> · 2017-06-19
Re: [PATCH rfc 03/30] nvme-rdma: reuse configure/destroy admin queue · Sagi Grimberg <sagi@grimberg.me> · 2017-06-19
[PATCH rfc 04/30] nvme-rdma: introduce configure/destroy io queues · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 04/30] nvme-rdma: introduce configure/destroy io queues · Christoph Hellwig <hch@lst.de> · 2017-06-19
[PATCH rfc 05/30] nvme-rdma: introduce nvme_rdma_start_queue · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 05/30] nvme-rdma: introduce nvme_rdma_start_queue · Christoph Hellwig <hch@lst.de> · 2017-06-19
[PATCH rfc 06/30] nvme-rdma: rename nvme_rdma_init_queue to nvme_rdma_alloc_queue · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 06/30] nvme-rdma: rename nvme_rdma_init_queue to nvme_rdma_alloc_queue · Christoph Hellwig <hch@lst.de> · 2017-06-19
[PATCH rfc 07/30] nvme-rdma: make stop/free queue receive a ctrl and qid struct · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 07/30] nvme-rdma: make stop/free queue receive a ctrl and qid struct · Christoph Hellwig <hch@lst.de> · 2017-06-19
[PATCH rfc 08/30] nvme-rdma: cleanup error path in controller reset · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 08/30] nvme-rdma: cleanup error path in controller reset · Christoph Hellwig <hch@lst.de> · 2017-06-19
Re: [PATCH rfc 08/30] nvme-rdma: cleanup error path in controller reset · James Smart <hidden> · 2017-07-10
[PATCH rfc 09/30] nvme: Move queue_count to the nvme_ctrl · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 09/30] nvme: Move queue_count to the nvme_ctrl · Christoph Hellwig <hch@lst.de> · 2017-06-19
[PATCH rfc 10/30] nvme: Add admin_tagset pointer to nvme_ctrl · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 10/30] nvme: Add admin_tagset pointer to nvme_ctrl · Christoph Hellwig <hch@lst.de> · 2017-06-19
Re: [PATCH rfc 10/30] nvme: Add admin_tagset pointer to nvme_ctrl · Sagi Grimberg <sagi@grimberg.me> · 2017-06-19
[PATCH rfc 11/30] nvme: move controller cap to struct nvme_ctrl · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 11/30] nvme: move controller cap to struct nvme_ctrl · Christoph Hellwig <hch@lst.de> · 2017-06-19
[PATCH rfc 12/30] nvme-rdma: disable controller in reset instead of shutdown · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 12/30] nvme-rdma: disable controller in reset instead of shutdown · Christoph Hellwig <hch@lst.de> · 2017-06-19
[PATCH rfc 13/30] nvme-rdma: move queue LIVE/DELETING flags settings to queue routines · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 13/30] nvme-rdma: move queue LIVE/DELETING flags settings to queue routines · Christoph Hellwig <hch@lst.de> · 2017-06-19
[PATCH rfc 14/30] nvme-rdma: stop queues instead of simply flipping their state · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 14/30] nvme-rdma: stop queues instead of simply flipping their state · Christoph Hellwig <hch@lst.de> · 2017-06-19
[PATCH rfc 15/30] nvme-rdma: don't check queue state for shutdown/disable · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 15/30] nvme-rdma: don't check queue state for shutdown/disable · Christoph Hellwig <hch@lst.de> · 2017-06-19
[PATCH rfc 16/30] nvme-rdma: move tagset allocation to a dedicated routine · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 16/30] nvme-rdma: move tagset allocation to a dedicated routine · Christoph Hellwig <hch@lst.de> · 2017-06-19
[PATCH rfc 17/30] nvme-rdma: move admin specific resources to alloc_queue · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 17/30] nvme-rdma: move admin specific resources to alloc_queue · Christoph Hellwig <hch@lst.de> · 2017-06-19
[PATCH rfc 18/30] nvme-rdma: limit max_queues to rdma device number of completion vectors · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
[PATCH rfc 19/30] nvme-rdma: call ops->reg_read64 instead of nvmf_reg_read64 · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
[PATCH rfc 20/30] nvme: add err, reconnect and delete work items to nvme core · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 20/30] nvme: add err, reconnect and delete work items to nvme core · Christoph Hellwig <hch@lst.de> · 2017-06-19
Re: [PATCH rfc 20/30] nvme: add err, reconnect and delete work items to nvme core · Sagi Grimberg <sagi@grimberg.me> · 2017-06-19
[PATCH rfc 21/30] nvme-rdma: plumb nvme_ctrl down the calls tack · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
[PATCH rfc 22/30] nvme-rdma: Split create_ctrl to transport specific and generic parts · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
[PATCH rfc 23/30] nvme: add low level queue and tagset controller ops · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
[PATCH rfc 24/30] nvme-pci: rename to nvme_pci_configure_admin_queue · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 24/30] nvme-pci: rename to nvme_pci_configure_admin_queue · Christoph Hellwig <hch@lst.de> · 2017-06-19
[PATCH rfc 25/30] nvme: move control plane handling to nvme core · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 25/30] nvme: move control plane handling to nvme core · Christoph Hellwig <hch@lst.de> · 2017-06-19
Re: [PATCH rfc 25/30] nvme: move control plane handling to nvme core · Sagi Grimberg <sagi@grimberg.me> · 2017-06-19
[PATCH rfc 26/30] nvme-fabrics: handle reconnects in fabrics library · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
[PATCH rfc 27/30] nvme-loop: convert to nvme-core control plane management · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
[PATCH rfc 28/30] nvme: update tagset nr_hw_queues when reallocating io queues · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 28/30] nvme: update tagset nr_hw_queues when reallocating io queues · Christoph Hellwig <hch@lst.de> · 2017-06-19
Re: [PATCH rfc 28/30] nvme: update tagset nr_hw_queues when reallocating io queues · Ming Lei <hidden> · 2017-06-19
Re: [PATCH rfc 28/30] nvme: update tagset nr_hw_queues when reallocating io queues · Sagi Grimberg <sagi@grimberg.me> · 2017-06-19
[PATCH rfc 29/30] nvme: add sed-opal ctrl manipulation in admin configuration · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 29/30] nvme: add sed-opal ctrl manipulation in admin configuration · Christoph Hellwig <hch@lst.de> · 2017-06-19
Re: [PATCH rfc 29/30] nvme: add sed-opal ctrl manipulation in admin configuration · Sagi Grimberg <sagi@grimberg.me> · 2017-06-19
Re: [PATCH rfc 29/30] nvme: add sed-opal ctrl manipulation in admin configuration · Christoph Hellwig <hch@lst.de> · 2017-06-19
[PATCH rfc 30/30] nvme: Add queue freeze/unfreeze handling on controller resets · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18
Re: [PATCH rfc 00/30] centralize nvme controller reset, delete and periodic reconnects · Sagi Grimberg <sagi@grimberg.me> · 2017-06-18

From: Sagi Grimberg <sagi@grimberg.me>
Date: 2017-06-19 08:00:45
Also in: linux-nvme

static int nvme_rdma_configure_admin_queue(struct nvme_rdma_ctrl *ctrl, bool new)

Too long line..

Also what about moving the helpers into the right place in the
previous patch that already re-indented most of this?

Sure.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help