Thread (17 messages) 17 messages, 5 authors, 2017-07-05

Re: [PATCH 1/1] blk-mq: map all HWQ also in hyperthreaded system

From: Sagi Grimberg <sagi@grimberg.me>
Date: 2017-06-29 05:33:36
Also in: linux-nvme

quoted
quoted
+static int cpu_to_queue_index(unsigned int nr_queues, const int cpu,
+                  const struct cpumask *online_mask)
  {
-    return cpu * nr_queues / nr_cpus;
+    /*
+     * Non online CPU will be mapped to queue index 0.
+     */
+    if (!cpumask_test_cpu(cpu, online_mask))
+        return 0;
Why not map offline cpus to what they would've map to if they were
online?
I didn't change logic for offline cpu's.
Should it be done in this patch ?
The patch clearly treats offline cpus differently, maps them
to queue 0.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help