On 06/16/2017 10:47 AM, Martin K. Petersen wrote:

Jens,

quoted

+static const unsigned int rwf_write_to_opf_flag[] = {
+	0, REQ_WRITE_SHORT, REQ_WRITE_MEDIUM, REQ_WRITE_LONG, REQ_WRITE_EXTREME
+};

Minor nit: When I see WRITE_SHORT I instinctively think data corruption.

Can we make these REQ_LIFETIME_SHORT or something instead? It loses the
WRITE moniker which I'm not so keen on. But I'm not sure how we'd define
read lifetime...

I did have that same feeling when writing it... The good news is that v6
will just use the WRITE_HINT_* types everywhere, so this one is already
gone.

-- 
Jens Axboe