Thread (6 messages) 6 messages, 1 author, 2017-06-16
STALE3299d REVIEWED: 1 (0M)
Revisions (3)
  1. v4 [diff vs current]
  2. v5 current
  3. v5 [diff vs current]

[xfstests PATCH v5 1/5] ext4: allow ext4 to use $SCRATCH_LOGDEV

From: Jeff Layton <hidden>
Date: 2017-06-16 19:36:15
Also in: linux-ext4, linux-fsdevel, linux-mm, linux-xfs
Subsystem: the rest · Maintainer: Linus Torvalds

The writeback error handling test requires that you put the journal on a
separate device. This allows us to use dmerror to simulate data
writeback failure, without affecting the journal.

xfs already has infrastructure for this (a'la $SCRATCH_LOGDEV), so wire
up the ext4 code so that it can do the same thing when _scratch_mkfs is
called.

Signed-off-by: Jeff Layton <redacted>
Reviewed-by: Darrick J. Wong <redacted>
---
 common/rc | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/common/rc b/common/rc
index ff1b75c9cd25..57001b47a8b7 100644
--- a/common/rc
+++ b/common/rc
@@ -679,6 +679,9 @@ _scratch_mkfs_ext4()
 	local tmp=`mktemp`
 	local mkfs_status
 
+	[ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_LOGDEV" ] && \
+	    $mkfs_cmd -O journal_dev $MKFS_OPTIONS $SCRATCH_LOGDEV && \
+	    mkfs_cmd="$mkfs_cmd -J device=$SCRATCH_LOGDEV"
 
 	_scratch_do_mkfs "$mkfs_cmd" "$mkfs_filter" $* 2>$tmp.mkfserr 1>$tmp.mkfsstd
 	mkfs_status=$?
-- 
2.13.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help