Re: [PATCH v2 5/8] blk-mq: update comments on blk_mq_quiesce_queue()
From: Bart Van Assche <hidden>
Date: 2017-05-30 17:14:55
From: Bart Van Assche <hidden>
Date: 2017-05-30 17:14:55
On Sat, 2017-05-27 at 22:21 +0800, Ming Lei wrote:
/** - * blk_mq_quiesce_queue() - wait until all ongoing queue_rq calls have f=
inished
+ * blk_mq_quiesce_queue() - wait until all ongoing dispatching have fini=
shed
* @q: request queue. *
Hello Ming, The concept of dispatching does not have a meaning to block driver authors = who are not familiar with the block layer internals. However, every author of a blk= -mq driver knows what the .queue_rq() function is. Additionally, the new comment is gr= ammatically incorrect. So the above change looks like a step in the wrong direction to = me. Bart.=