On Thu, 2017-05-25 at 14:48 -0400, J . Bruce Fields wrote:

On Thu, May 25, 2017 at 11:43:14AM -0700, Bart Van Assche wrote:

quoted

Since using scsi_req() is only allowed against request queues for
which struct scsi_request is the first member of their private
request data, refuse to submit SCSI commands against a queue for
which this is not the case.

=20
Is it possible we could catch this earlier and avoid giving out the
layout in the first place?

Hello Christoph,

According to what I see in commit 8650b8a05850 you are the author of this
code? Can the blk_queue_scsi_pdu(q) test fail in nfsd4_scsi_identify_device=
()?
If so, can nfsd4_layout_verify() be modified in such a way that it prevents
that nfsd4_scsi_proc_getdeviceinfo() is ever called for a non-SCSI queue?
Can you recommend an approach?

Thanks,

Bart.=