Thread (8 messages) 8 messages, 2 authors, 2017-05-15

Re: [PATCH 1/4] dm rq: add a missing break to map_request

From: Mike Snitzer <hidden>
Date: 2017-05-15 18:25:12
Also in: dm-devel

On Mon, May 15 2017 at 11:28am -0400,
Christoph Hellwig [off-list ref] wrote:
quoted hunk ↗ jump to hunk
We don't want to bug when receiving a DM_MAPIO_KILL value..

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/md/dm-rq.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/md/dm-rq.c b/drivers/md/dm-rq.c
index 2af27026aa2e..b639fa7246ee 100644
--- a/drivers/md/dm-rq.c
+++ b/drivers/md/dm-rq.c
@@ -507,6 +507,7 @@ static int map_request(struct dm_rq_target_io *tio)
 	case DM_MAPIO_KILL:
 		/* The target wants to complete the I/O */
 		dm_kill_unmapped_request(rq, -EIO);
+		break;
 	default:
 		DMWARN("unimplemented target map return value: %d", r);
 		BUG();
-- 
2.11.0
Thanks, but I have no idea how this happened.  I specifically recall
fixing this very same issue (missing break).  Grr...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help