Thread (13 messages) 13 messages, 3 authors, 2017-05-25

Re: [PATCH BUGFIX] block, bfq: access and cache blkg data only when safe

From: Paolo Valente <hidden>
Date: 2017-05-22 20:20:10
Also in: lkml

Il giorno 19 mag 2017, alle ore 16:37, Jens Axboe [off-list ref] ha =
scritto:
=20
On 05/19/2017 02:39 AM, Paolo Valente wrote:
quoted
@@ -692,8 +725,7 @@ void bfq_pd_offline(struct blkg_policy_data *pd)
		/*
		 * The idle tree may still contain bfq_queues belonging
		 * to exited task because they never migrated to a =
different
quoted
-		 * cgroup from the one being destroyed now.  No one else
-		 * can access them so it's safe to act without any lock.
++                * cgroup from the one being destroyed now.
		 */
		bfq_flush_idle_tree(st);
=20
=20
Looks like an extra '+' snuck into that hunk.
=20
Yes, sorry.  Before possibly submitting a fixed version, I'll wait for
a reply on my previous email in this thread, as the issue now seems
more serious to me, and affecting CFQ too.

Thanks,
Paolo
--=20
Jens Axboe
=20
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help