On 04/11/2017 12:00 PM, Bart Van Assche wrote:

On Mon, 2017-04-10 at 09:54 -0600, Jens Axboe wrote:

quoted

 void blk_mq_stop_hw_queue(struct blk_mq_hw_ctx *hctx)
 {
-	cancel_work(&hctx->run_work);
+	cancel_delayed_work(&hctx->run_work);
 	cancel_delayed_work(&hctx->delay_work);
 	set_bit(BLK_MQ_S_STOPPED, &hctx->state);
 }

Hello Jens,

I would like to change the above cancel_*work() calls into cancel_*work_sync()
calls because this code is used when e.g. switching between I/O schedulers and
no .queue_rq() calls must be ongoing while switching between schedulers. Do you
want to integrate that change into this patch or do you want me to post a
separate patch? In the latter case, should I start from your for-next branch
to develop that patch or from your for-next branch + this patch series?

I agree, we should make it _sync(). I'll just make the edit in the patch
when I send it out again. I was waiting for further comments on patch 3/3.

-- 
Jens Axboe