On Sat, Mar 25, 2017 at 2:45 AM, Bart Van Assche
[off-list ref] wrote:

On Sat, 2017-03-25 at 01:38 +0800, Ming Lei wrote:

quoted

As I explained, the dying flag should only be mentioned after we change
the code in blk_set_queue_dying().

Hello Ming,

If patches 2 and 4 would be combined into a single patch then it wouldn't
be necessary anymore to update the comment introduced in patch 2 in patch 4.
I think that would make this patch series easier to review.

I think it is better to not do that, because we know patch 2 and patch
4 are doing
two different things, and patch 2 can be thought as one fix, but patch 4 should
be a improvement.  And it is normal to update comment after code changes.

Since the issues fixed by your patches are longstanding issues, have you
considered to add a "Cc: stable" tag?

I don't know because there isn't real report, and maybe never, so I leave it
alone.


Thanks,
Ming Lei