Re: [PATCH 06/16] mmc: core: replace waitqueue with worker

On 03/14/2017 08:43 AM, Christoph Hellwig wrote:

On Tue, Mar 14, 2017 at 08:36:26AM -0600, Jens Axboe wrote:

quoted

There's one case that doesn't look like it was converted properly, but
that's a mistake. The general insert-and-run cases run inline if we can,
but the direct-issue needs a fixup, see below.

Note that blk_mq_try_issue_directly is only called for the multiple
hardware queue case, so MMC would not hit it.

Right, which is why I said that the general case works fine, it's
only the explicit issue-direct that currently does not. Not by
design, just an error.

-- 
Jens Axboe