Thread (5 messages) 5 messages, 3 authors, 2017-03-14

Re: [PATCH] blk-mq-sched: don't run the queue async from blk_mq_try_issue_directly()

From: Jens Axboe <axboe@kernel.dk>
Date: 2017-03-14 15:26:08

On 03/14/2017 09:17 AM, Bart Van Assche wrote:
On 03/14/2017 07:57 AM, Jens Axboe wrote:
quoted
If we have scheduling enabled, we jump directly to insert-and-run.
That's fine, but we run the queue async and we don't pass in information
on whether we can block from this context or not. Fixup both these
cases.
How about renaming "can_block" into "may_sleep"? Otherwise this patch
looks fine to me.
Sure, either one is fine with me, at least to me they convey the same
information.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help